Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the Anthias installer so that it'll work on Debian Bookworm as well #1836

Merged
merged 51 commits into from
Apr 2, 2024

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Oct 23, 2023

Overview

How to run the installer script?

cd && \
echo "export CUSTOM_BRANCH='fix-installer'" > .env && \
bash <(curl -sL https://raw.githubusercontent.com/nicomiguelino/Anthias/fix-installer/bin/install.sh)

@nicomiguelino nicomiguelino marked this pull request as ready for review October 25, 2023 22:21
@nicomiguelino nicomiguelino requested a review from a team as a code owner October 25, 2023 22:21
@MuratUrsavas
Copy link

Could you fix Ansible Linter errors?

@nicomiguelino nicomiguelino marked this pull request as draft October 26, 2023 16:13
@nicomiguelino
Copy link
Contributor Author

@vpetersson, @MuratUrsavas
With the recent changes, I got it working on my Pi 4.
I'm still testing it on other Pi models (Pi 3, Pi 2).

@vpetersson
Copy link
Contributor

Ping @salmanfarisvp to test it on Pi 5 too.

@nicomiguelino nicomiguelino marked this pull request as ready for review November 9, 2023 06:07
Copy link
Contributor

@vpetersson vpetersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we can't just drop the dtoverlay=vc4-fkms-v3d. Perhaps that works in Bookworm but what about the release before?

@salmanfarisvp
Copy link
Contributor

Update - Tested on Pi5 - 8GB - Bookworm Lite 64-bit
-> Screen blank after the reboot, Just a cursor blinking
-> Tried with and without the system upgrade option from the script.

@nicomiguelino
Copy link
Contributor Author

@salmanfarisvp, I'll just post what you've discussed earlier outside GitHub.

Raspberry Pi 3 Model B - Test Results

  • OS: Bullseye (64-bit)
  • The installer's stuck during DHCP. A restart (with power cycle) is needed. (Not much can be done here).
    • @salmanfarisvp, have you said yes to manage network when you're prompted?
  • When no was given for network management and system update, Anthias is working fine.

@salmanfarisvp
Copy link
Contributor

@nicomiguelino Yes, I was using WiFi and it's been set by the Raspberry Pi imager. When I said NO to the system upgrade and Network manager, it completed the installation and booted fine.

@nicomiguelino
Copy link
Contributor Author

@salmanfarisvp, is Wi-Fi the only Internet connectivity your device has?
(Is it connected via the Ethernet as well.)

  • I've experienced the same before, that's why I resorted to using Ethernet, as the installer always gets stuck at some point (when connected to Wi-Fi, with network management enabled).

@salmanfarisvp
Copy link
Contributor

Yeah for now I only used WiFi. I will try with ethernet. Is the WiFi setup a known bug then?

@nicomiguelino
Copy link
Contributor Author

Yeah for now I only used WiFi. I will try with ethernet. Is the WiFi setup a known bug then?

Yes, it's a bug.

@salmanfarisvp
Copy link
Contributor

@nicomiguelino Added a new issue #1845

@nicomiguelino
Copy link
Contributor Author

I'm pretty sure we can't just drop the dtoverlay=vc4-fkms-v3d. Perhaps that works in Bookworm but what about the release before?

Yes, you're right @vpetersson. I forgot to bring it back, thanks. Just pushed a commit bringing that part back for Pi 4 devices running Debian 11 (Bullseye) and older.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bozzer91
Copy link

Update - Tested on Pi5 - 8GB - Bookworm Lite 64-bit

-> Screen blank after the reboot, Just a cursor blinking

-> Tried with and without the system upgrade option from the script.

If it helps I can confirm this tried it yesterday with the same results blank screen blinking cursor.

@nicomiguelino nicomiguelino requested a review from vpetersson April 1, 2024 18:21
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nicomiguelino nicomiguelino merged commit 503498e into Screenly:master Apr 2, 2024
5 of 6 checks passed
@nicomiguelino
Copy link
Contributor Author

@bozzer91, @salmanfarisvp, @vpetersson
Pi 5 compatibility will be resolved on a separate PR.

@nicomiguelino nicomiguelino deleted the fix-installer branch April 2, 2024 06:42
@nicomiguelino nicomiguelino mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/home/$USER/screenly/bin/upgrade_containers.sh does not exist
5 participants